Page MenuHomePhabricator
Differential D138201

[AVR] Fix wrong ABI on AVRTiny.
ClosedPublic
Actions

Authored by benshi001 on Nov 17 2022, 4:40 AM.

Details

Reviewers
dylanmckay
aykevl
Commits
rGf452b9dcaff5: [AVR] Fix wrong ABI of AVRTiny.
Summary

A scalar exceeds 4 bytes should be returned via stack
other than registers, on an AVRTiny device.

Diff Detail

Unit TestsFailed
View All

TimeTest
60,090 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp 2>&1 | FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp
60,050 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/NullDerefTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/minimize_crash.test.tmp-NullDerefTest

Event Timeline

benshi001 created this revision.Nov 17 2022, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2022, 4:40 AM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
benshi001 requested review of this revision.Nov 17 2022, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2022, 4:40 AM
Herald added subscribers: llvm-commits, jacquesguan. · View Herald Transcript
benshi001 added inline comments.Nov 17 2022, 4:42 AM
llvm/test/CodeGen/AVR/return.ll
96

This case clearly shows that an i32 value is returned via registers on both AVR and AVRTiny.

150

This case clearly shows that an i64 is returned via registers on AVR, while via stack on AVRTiny.

benshi001 mentioned this in D131867: [AVR] Do not emit instructions invalid for attiny10.Nov 17 2022, 4:50 AM
benshi001 mentioned this in D121672: [AVR] Reject/Reserve R0~R15 on AVRTiny.
Harbormaster completed remote builds in B198185: Diff 476089.Nov 17 2022, 5:42 AM
aykevl accepted this revision.Nov 22 2022, 4:27 PM

Looks good to me.

For a future patch, it would be easier to review if you update test files to use update_llc_test_checks.py in a separate patch. That makes it much easier to see what actually changed.

This revision is now accepted and ready to land.Nov 22 2022, 4:27 PM
This revision was landed with ongoing or failed builds.Nov 22 2022, 5:33 PM
Closed by commit rGf452b9dcaff5: [AVR] Fix wrong ABI of AVRTiny. (authored by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rGf452b9dcaff5: [AVR] Fix wrong ABI of AVRTiny..
benshi001 added a comment.Nov 22 2022, 5:34 PM
In D138201#3945354, @aykevl wrote:

Looks good to me.

For a future patch, it would be easier to review if you update test files to use update_llc_test_checks.py in a separate patch. That makes it much easier to see what actually changed.

Sure. Thanks.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AVR/
10 lines
test/
CodeGen/
AVR/
348 lines

Diff 476089

View Options

llvm/lib/Target/AVR/AVRISelLowering.cpp

Loading...
View Options

llvm/test/CodeGen/AVR/return.ll

Loading...