This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Tensor] Clean-up `ops.mlir` test (NFC)
ClosedPublic

Authored by chelini on Nov 15 2022, 1:43 AM.

Details

Diff Detail

Event Timeline

chelini created this revision.Nov 15 2022, 1:43 AM
chelini requested review of this revision.Nov 15 2022, 1:43 AM
chelini updated this revision to Diff 475376.Nov 15 2022, 1:51 AM

Improve test gather_scatter.

springerm added inline comments.Nov 16 2022, 2:15 AM
mlir/test/Dialect/Tensor/ops.mlir
280

This should not be deleted. Otherwise, some of the CHECKs may accidentally match IR from different tests.

chelini added inline comments.Nov 16 2022, 3:12 AM
mlir/test/Dialect/Tensor/ops.mlir
280

I have moved the statement few lines below (line 277).

chelini added inline comments.Nov 16 2022, 3:15 AM
mlir/test/Dialect/Tensor/ops.mlir
280

Ignore me. Got it. I will fix it.

springerm accepted this revision.Nov 16 2022, 3:52 AM
This revision is now accepted and ready to land.Nov 16 2022, 3:52 AM
This revision was automatically updated to reflect the committed changes.