Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D137914

[cmake] Simplify llvm_update_compile_flags
Needs ReviewPublic
Actions

Authored by Trass3r on Nov 13 2022, 2:44 PM.

Tags

Subscribers

Details

Reviewers

davezarzycki
phosek
ldionne

Summary

Using modern CMake for language-specific flags.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Trass3r created this revision.Nov 13 2022, 2:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2022, 2:44 PM

Trass3r requested review of this revision.Nov 13 2022, 2:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2022, 2:44 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B197435: Diff 475018.Nov 13 2022, 3:31 PM

Trass3r added reviewers: phosek, ldionne.Dec 2 2022, 12:44 AM

LGTM but I have never used that function. I don't think the runtimes make use of it.

ldionne resigned from this revision.Sep 8 2023, 5:58 AM

Herald added a subscriber: ekilmer. · View Herald TranscriptSep 8 2023, 5:58 AM

Revision Contents
Changeset List

Path

Size

llvm/

cmake/

modules/

34 lines

Diff 475018

llvm/cmake/modules/AddLLVM.cmake

Loading...