This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse][NFC] Add comments to tests that are run for with and without runtime libraries.
ClosedPublic

Authored by bixia on Nov 11 2022, 2:26 PM.

Diff Detail

Event Timeline

bixia created this revision.Nov 11 2022, 2:26 PM
Herald added a project: Restricted Project. · View Herald Transcript
bixia requested review of this revision.Nov 11 2022, 2:26 PM
aartbik accepted this revision.Nov 11 2022, 3:41 PM
aartbik added inline comments.
mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output.mlir
8

super, super, nit, but can you add a // after this so it jump out more
(as done elsewhere too)

This revision is now accepted and ready to land.Nov 11 2022, 3:41 PM
bixia updated this revision to Diff 475149.Nov 14 2022, 7:50 AM
bixia marked an inline comment as done.

Add // to connect the commands for the two runs.

This revision was landed with ongoing or failed builds.Nov 14 2022, 8:21 AM
This revision was automatically updated to reflect the committed changes.