This is an archive of the discontinued LLVM Phabricator instance.

Differential D137701

[flang][NFC] move HLFIR dialect definition in IR
ClosedPublic

Authored by jeanPerier on Nov 9 2022, 2:03 AM.

Details

Reviewers
clementval
nicolasvasilache
Commits
rGaf8cec4c1696: [flang][NFC] move HLFIR dialect definition in IR
Summary

Transforms will need to be put in a different library to avoid circular
dependencies with other parts of the compiler. So create an IR
directory, this (flat include directory, IR and Transform directories in
lib) matches how dialects like LLVM dialect are implemented.

Diff Detail

Event Timeline

jeanPerier created this revision.Nov 9 2022, 2:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2022, 2:03 AM
Herald added subscribers: mehdi_amini, jdoerfert. · View Herald Transcript
jeanPerier requested review of this revision.Nov 9 2022, 2:03 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 9 2022, 2:03 AM
Harbormaster completed remote builds in B196856: Diff 474197.Nov 9 2022, 2:19 AM
clementval accepted this revision.Nov 9 2022, 2:35 AM

LGTM

This revision is now accepted and ready to land.Nov 9 2022, 2:35 AM
Closed by commit rGaf8cec4c1696: [flang][NFC] move HLFIR dialect definition in IR (authored by jeanPerier). · Explain WhyNov 9 2022, 2:40 AM
This revision was automatically updated to reflect the committed changes.
jeanPerier added a commit: rGaf8cec4c1696: [flang][NFC] move HLFIR dialect definition in IR.

Revision Contents

PathSize
flang/
lib/
Optimizer/
HLFIR/
21 lines
IR/

Diff 474208

flang/lib/Optimizer/HLFIR/CMakeLists.txt

  • This file was copied to flang/lib/Optimizer/HLFIR/IR/CMakeLists.txt.
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) add_subdirectory(IR)
add_flang_library(HLFIRDialect
HLFIRDialect.cpp
DEPENDS
FIRDialect
HLFIROpsIncGen
${dialect_libs}
LINK_LIBS
FIRDialect
MLIRIR
${dialect_libs}
LINK_COMPONENTS
AsmParser
AsmPrinter
Remarks
)

flang/lib/Optimizer/HLFIR/HLFIRDialect.cpp

  • This file was moved to flang/lib/Optimizer/HLFIR/IR/HLFIRDialect.cpp.

flang/lib/Optimizer/HLFIR/IR/CMakeLists.txt

  • This file was copied from flang/lib/Optimizer/HLFIR/CMakeLists.txt.
The contents of this file were not changed.

flang/lib/Optimizer/HLFIR/IR/HLFIRDialect.cpp

  • This file was moved from flang/lib/Optimizer/HLFIR/HLFIRDialect.cpp.
The contents of this file were not changed.