This is an archive of the discontinued LLVM Phabricator instance.

Differential D137686

[X86] Add In64BitMode requirement for MMXRI
ClosedPublic

Authored by HaohaiWen on Nov 8 2022, 6:36 PM.

Details

Reviewers
skan
Commits
rGb17b25dde069: [X86] Add In64BitMode requirement for MMXRI
Summary

REX_W prefix is only encodable in 64bit.

Diff Detail

Event Timeline

HaohaiWen created this revision.Nov 8 2022, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2022, 6:36 PM
Herald added subscribers: pengfei, hiraditya. · View Herald Transcript
HaohaiWen requested review of this revision.Nov 8 2022, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2022, 6:36 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
HaohaiWen added a reviewer: skan.Nov 8 2022, 6:37 PM
skan accepted this revision.Nov 8 2022, 6:48 PM

Good catch!

This revision is now accepted and ready to land.Nov 8 2022, 6:48 PM
Harbormaster completed remote builds in B196811: Diff 474139.Nov 8 2022, 7:24 PM
Closed by commit rGb17b25dde069: [X86] Add In64BitMode requirement for MMXRI (authored by HaohaiWen). · Explain WhyNov 8 2022, 10:08 PM
This revision was automatically updated to reflect the committed changes.
HaohaiWen added a commit: rGb17b25dde069: [X86] Add In64BitMode requirement for MMXRI.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
3 lines

Diff 474152

llvm/lib/Target/X86/X86InstrFormats.td

Show First 20 Lines • Show All 1,006 Lines • ▼ Show 20 Lines
class MMXI32<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXI32<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: I<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX,Not64BitMode]>; : I<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX,Not64BitMode]>;
class MMXI64<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXI64<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: I<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX,In64BitMode]>; : I<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX,In64BitMode]>;
class MMXRI<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXRI<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: I<o, F, outs, ins, asm, pattern>, PS, REX_W, Requires<[HasMMX]>; : I<o, F, outs, ins, asm, pattern>, PS, REX_W,
Requires<[HasMMX,In64BitMode]>;
class MMX2I<bits<8> o, Format F, dag outs, dag ins, string asm, class MMX2I<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: I<o, F, outs, ins, asm, pattern>, PD, Requires<[HasMMX]>; : I<o, F, outs, ins, asm, pattern>, PD, Requires<[HasMMX]>;
class MMXIi8<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXIi8<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: Ii8<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX]>; : Ii8<o, F, outs, ins, asm, pattern>, PS, Requires<[HasMMX]>;
class MMXID<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXID<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: Ii8<o, F, outs, ins, asm, pattern>, XD, Requires<[HasMMX]>; : Ii8<o, F, outs, ins, asm, pattern>, XD, Requires<[HasMMX]>;
class MMXIS<bits<8> o, Format F, dag outs, dag ins, string asm, class MMXIS<bits<8> o, Format F, dag outs, dag ins, string asm,
list<dag> pattern> list<dag> pattern>
: Ii8<o, F, outs, ins, asm, pattern>, XS, Requires<[HasMMX]>; : Ii8<o, F, outs, ins, asm, pattern>, XS, Requires<[HasMMX]>;