This patch brings std::ios_base::noreplace in P2467R1 to libcxx.
Since I am new to the community, I do not quite know who is suitable to review my patch, so if there is better choice as reviewers in your mind, please add to "reviewers". So thanks!
Differential D137640
[libcxx] Implement P2467R1: Support exclusive mode for fstreams PragmaTwice on Nov 8 2022, 6:28 AM. Authored by
Details This patch brings std::ios_base::noreplace in P2467R1 to libcxx. Since I am new to the community, I do not quite know who is suitable to review my patch, so if there is better choice as reviewers in your mind, please add to "reviewers". So thanks!
Diff Detail
Event TimelineComment Actions Thanks for working on this! Please goo through https://libcxx.llvm.org/Contributing.html#pre-commit-check-list and make sure that you did everything listed there.
Comment Actions Thanks for the patch! This looks reasonable but I think we're missing coverage.
Comment Actions add since C++23 comment
Comment Actions Please also add a release note to libcxx/docs/ReleaseNotes.rst under the Implemented Papers section and make sure CI is green (you probably have to rebase). Comment Actions I didn't do a review, I was mainly curious what this paper did. I did discover one small issue.
Comment Actions Thanks for adding test coverage! This looks good to me, however we have several CI failures that would need to be fixed. It looks like UBSan, Windows and a few others are not happy with this change as-is. |