This is an archive of the discontinued LLVM Phabricator instance.

Differential D137573

[AVR] Add FeatureEIJMPCALL to FamilyAVR6
ClosedPublic

Authored by aykevl on Nov 7 2022, 10:01 AM.

Details

Reviewers
benshi001
dylanmckay
Commits
rGa8673b722989: [AVR] Add FeatureEIJMPCALL to FamilyAVR6
Summary

This feature was probably missed when FamilyAVR6, but should definitely be there. I checked all four devices in the AVR6 family and they all support eijmp/eicall.

Found while working on D137572 (but this patch can be applied separately).

Diff Detail

Event Timeline

aykevl created this revision.Nov 7 2022, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 10:01 AM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
aykevl requested review of this revision.Nov 7 2022, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 10:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B196528: Diff 473728.Nov 7 2022, 12:11 PM
benshi001 accepted this revision.Nov 10 2022, 10:50 PM

LGTM

This revision is now accepted and ready to land.Nov 10 2022, 10:50 PM
benshi001 added a comment.Nov 11 2022, 12:37 AM

You are appreciated to commit ASAP. I would like to reduce my long review list. :)

This revision was landed with ongoing or failed builds.Nov 15 2022, 6:29 AM
Closed by commit rGa8673b722989: [AVR] Add FeatureEIJMPCALL to FamilyAVR6 (authored by aykevl). · Explain Why
This revision was automatically updated to reflect the committed changes.
aykevl added a commit: rGa8673b722989: [AVR] Add FeatureEIJMPCALL to FamilyAVR6.

Revision Contents

PathSize
llvm/
lib/
Target/
AVR/
2 lines

Diff 475451

llvm/lib/Target/AVR/AVRDevices.td

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Linesdef FamilyAVR4 : Family<"avr4",
FeatureLPMX, FeatureSPM, FeatureBREAK]>; FeatureLPMX, FeatureSPM, FeatureBREAK]>;
def FamilyAVR5 : Family<"avr5", def FamilyAVR5 : Family<"avr5",
[FamilyAVR3, FeatureMultiplication, FeatureMOVW, [FamilyAVR3, FeatureMultiplication, FeatureMOVW,
FeatureLPMX, FeatureSPM, FeatureBREAK]>; FeatureLPMX, FeatureSPM, FeatureBREAK]>;
def FamilyAVR51 : Family<"avr51", [FamilyAVR5, FeatureELPM, FeatureELPMX]>; def FamilyAVR51 : Family<"avr51", [FamilyAVR5, FeatureELPM, FeatureELPMX]>;
def FamilyAVR6 : Family<"avr6", [FamilyAVR51]>; def FamilyAVR6 : Family<"avr6", [FamilyAVR51, FeatureEIJMPCALL]>;
def FamilyTiny def FamilyTiny
: Family<"avrtiny", : Family<"avrtiny",
[FamilyAVR0, FeatureBREAK, FeatureSRAM, FeatureTinyEncoding, [FamilyAVR0, FeatureBREAK, FeatureSRAM, FeatureTinyEncoding,
FeatureSmallStack]>; FeatureSmallStack]>;
def FamilyXMEGA3 : Family<"xmega3", def FamilyXMEGA3 : Family<"xmega3",
[FamilyAVR0, FeatureLPM, FeatureIJMPCALL, [FamilyAVR0, FeatureLPM, FeatureIJMPCALL,
▲ Show 20 Lines • Show All 363 Lines • Show Last 20 Lines