This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add implementations of ftell.
ClosedPublic

Authored by sivachandra on Nov 4 2022, 12:20 AM.

Diff Detail

Event Timeline

sivachandra created this revision.Nov 4 2022, 12:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 4 2022, 12:20 AM
sivachandra requested review of this revision.Nov 4 2022, 12:20 AM

Sorry, this is WiP and not complete - not sure why I did an arc diff instead of saving the work with git commit. I will update and ping when ready.

lntue accepted this revision.Nov 4 2022, 12:49 PM
This revision is now accepted and ready to land.Nov 4 2022, 12:49 PM

Uploading a complete implementation of ftell and ftello.

The patch is now complete.

Remove ftello - we will add it when we are more prepared to deal with
off_t variances.

sivachandra retitled this revision from [libc] Add implementations of ftell and ftello. to [libc] Add implementations of ftell..Nov 5 2022, 7:45 PM
lntue added inline comments.Nov 7 2022, 10:46 AM
libc/config/linux/api.td
160

Is off_t being used any where in the patch? Or just definition to be included in the headers?

Remove off_t from spec and config for stdio.h as it is not used anymore.

sivachandra added inline comments.Nov 7 2022, 1:17 PM
libc/config/linux/api.td
160

Ah yes! Removed now, from here and from spec/posix.td.

This revision was automatically updated to reflect the committed changes.