This is an archive of the discontinued LLVM Phabricator instance.

Differential D137372

[Test][[AIX][pg] Add 32-bit linker invocation tests
ClosedPublic

Authored by francii on Nov 3 2022, 3:53 PM.

Details

Reviewers
hubert.reinterpretcast
cebowleratibm
xingxue

Diff Detail

Event Timeline

francii created this revision.Nov 3 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 3:53 PM
francii requested review of this revision.Nov 3 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 3:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
francii added reviewers: hubert.reinterpretcast, cebowleratibm.Nov 3 2022, 3:54 PM
francii retitled this revision from [AIX][pg] Add 32-bit test case to [AIX][pg] Add 32-bit Test Case.
francii edited the summary of this revision. (Show Details)Nov 3 2022, 3:59 PM
Harbormaster completed remote builds in B196021: Diff 473066.Nov 3 2022, 4:22 PM
francii added a reviewer: xingxue.Nov 6 2022, 12:58 PM
francii retitled this revision from [AIX][pg] Add 32-bit Test Case to [AIX][pg] Add 32-bit Test Case to Linker Tests.
francii edited the summary of this revision. (Show Details)Nov 6 2022, 4:58 PM
cebowleratibm added a comment.Nov 7 2022, 9:21 AM

Use the [Test] tag in the abstract.

Suggest: "[Test][AIX][pg] Add 32-bit expected driver output"

No need for a summary.

francii retitled this revision from [AIX][pg] Add 32-bit Test Case to Linker Tests to [Test][[AIX][pg] Add 32-bit Test Case to Linker Tests.Nov 7 2022, 9:25 AM
francii retitled this revision from [Test][[AIX][pg] Add 32-bit Test Case to Linker Tests to [Test][[AIX][pg] Add 32-bit linker invocation tests.Nov 8 2022, 11:29 AM
francii edited the summary of this revision. (Show Details)
cebowleratibm accepted this revision.Nov 9 2022, 11:17 AM

LGTM.

Test only patch is safe to commit.

This revision is now accepted and ready to land.Nov 9 2022, 11:17 AM
cebowleratibm mentioned this in rGe07a7040d9c6: [Test][AIX][pg] Add 32-bit linker invocation tests.Nov 9 2022, 12:03 PM
francii closed this revision.Mar 20 2023, 5:46 PM

Closing as this revision has landed

https://reviews.llvm.org/rGe07a7040d9c6dbdd71e55d1153bfe1357079e511

Revision Contents

PathSize
clang/
test/
Driver/
27 lines

Diff 473066

clang/test/Driver/aix-ld.c

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
// CHECK-LD32-PROF-NOT: "-lc++abi" // CHECK-LD32-PROF-NOT: "-lc++abi"
// CHECK-LD32-PROF: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc.a" // CHECK-LD32-PROF: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc.a"
// CHECK-LD32-PROF-NOT: "--as-needed" // CHECK-LD32-PROF-NOT: "--as-needed"
// CHECK-LD32-PROF: "-lunwind" // CHECK-LD32-PROF: "-lunwind"
// CHECK-LD32-PROF-NOT: "--no-as-needed" // CHECK-LD32-PROF-NOT: "--no-as-needed"
// CHECK-LD32-PROF-NOT: "-lm" // CHECK-LD32-PROF-NOT: "-lm"
// CHECK-LD32-PROF: "-lc" // CHECK-LD32-PROF: "-lc"
// Check powerpc-ibm-aix7.1.0.0, 32-bit. Enable g-profiling.
// RUN: %clang %s -### 2>&1 \
// RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: -pg \
// RUN: --target=powerpc-ibm-aix7.1.0.0 \
// RUN: --sysroot %S/Inputs/aix_ppc_tree \
// RUN: --unwindlib=libunwind \
// RUN: | FileCheck --check-prefix=CHECK-LD32-GPROF %s
// CHECK-LD32-GPROF-NOT: warning:
// CHECK-LD32-GPROF: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0"
// CHECK-LD32-GPROF: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK-LD32-GPROF: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK-LD32-GPROF: "{{.*}}ld{{(.exe)?}}"
// CHECK-LD32-GPROF-NOT: "-bnso"
// CHECK-LD32-GPROF: "-b32"
// CHECK-LD32-GPROF: "-bpT:0x10000000" "-bpD:0x20000000"
// CHECK-LD32-GPROF: "[[SYSROOT]]/usr/lib{{/|\\\\}}gcrt0.o"
// CHECK-LD32-GPROF: "[[SYSROOT]]/usr/lib{{/|\\\\}}crti.o"
// CHECK-LD32-GPROF-NOT: "-lc++"
// CHECK-LD32-GPROF-NOT: "-lc++abi"
// CHECK-LD32-GPROF: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc.a"
// CHECK-LD32-GPROF-NOT: "--as-needed"
// CHECK-LD32-GPROF: "-lunwind"
// CHECK-LD32-GPROF-NOT: "--no-as-needed"
// CHECK-LD32-GPROF-NOT: "-lm"
// CHECK-LD32-GPROF: "-lc"
// Check powerpc64-ibm-aix7.1.0.0, 64-bit. Enable g-profiling. // Check powerpc64-ibm-aix7.1.0.0, 64-bit. Enable g-profiling.
// RUN: %clang %s -### 2>&1 \ // RUN: %clang %s -### 2>&1 \
// RUN: -resource-dir=%S/Inputs/resource_dir \ // RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: -pg \ // RUN: -pg \
// RUN: --target=powerpc64-ibm-aix7.1.0.0 \ // RUN: --target=powerpc64-ibm-aix7.1.0.0 \
// RUN: --sysroot %S/Inputs/aix_ppc_tree \ // RUN: --sysroot %S/Inputs/aix_ppc_tree \
// RUN: --unwindlib=libunwind \ // RUN: --unwindlib=libunwind \
// RUN: | FileCheck --check-prefix=CHECK-LD64-GPROF %s // RUN: | FileCheck --check-prefix=CHECK-LD64-GPROF %s
▲ Show 20 Lines • Show All 814 Lines • Show Last 20 Lines