This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer][test] Fix FastUnwindTest on LoongArch
ClosedPublic

Authored by tangyouling on Nov 2 2022, 9:24 PM.

Details

Summary

Fixes the FastUnwindTest unit test for LoongArch.
This change is similar to RISCV D90574.

The following test cases pass after applying the patch:

$ ./runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/tests/Sanitizer-loongarch64-Test
...
[  FAILED  ] FastUnwindTest.Basic
[  FAILED  ] FastUnwindTest.FramePointerLoop
[  FAILED  ] FastUnwindTest.MisalignedFramePointer
[  FAILED  ] FastUnwindTest.FPBelowPrevFP
[  FAILED  ] FastUnwindTest.CloseToZeroFrame

Diff Detail

Event Timeline

tangyouling created this revision.Nov 2 2022, 9:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 9:24 PM
tangyouling requested review of this revision.Nov 2 2022, 9:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 9:24 PM
Herald added subscribers: Restricted Project, pcwang-thead. · View Herald Transcript
xen0n accepted this revision.Nov 2 2022, 10:38 PM
This revision is now accepted and ready to land.Nov 2 2022, 10:38 PM
xen0n added a comment.Nov 2 2022, 10:38 PM

Hmm, better yet, place LoongArch define ahead of the RISCV define, so the list appears alphabetically sorted.

Address @xen0n's comments.

MaskRay accepted this revision.Nov 3 2022, 6:14 PM
SixWeining accepted this revision.Nov 5 2022, 11:26 PM
This revision was automatically updated to reflect the committed changes.