This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AArch64]Precommit test for D135102
ClosedPublic

Authored by mingmingl on Nov 2 2022, 3:46 PM.

Details

Summary
  • Run auto updater for 'trunc-to-tbl.ll' and 'build-pair-isel.ll'
  • Add the motivating test of D135102 to 'bitfield-insert.ll'

Diff Detail

Event Timeline

mingmingl created this revision.Nov 2 2022, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 3:46 PM
mingmingl requested review of this revision.Nov 2 2022, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 3:46 PM
fhahn accepted this revision.Nov 3 2022, 6:00 AM
fhahn added a subscriber: fhahn.

LGTM, thanks!

llvm/test/CodeGen/AArch64/trunc-to-tbl.ll
298

nit: stray new line?

361

nit: stray new line?

458

nit: stray new line?

539

nit: stray new line?

This revision is now accepted and ready to land.Nov 3 2022, 6:00 AM
mingmingl updated this revision to Diff 472972.Nov 3 2022, 9:56 AM
mingmingl marked 4 inline comments as done.

Resolve comments.

Thanks!

llvm/test/CodeGen/AArch64/trunc-to-tbl.ll
298

Done (for the other three as well).

These new lines were somehow added by auto-updater so thought I would just keep them.

I removed them just now, and git rebase --continue in D135102 won't re-add it, so going to remove them for now.

This revision was automatically updated to reflect the committed changes.