This is an archive of the discontinued LLVM Phabricator instance.

[JITLink] Fix check-line in Windows X86 COFF COMDAT test
ClosedPublic

Authored by sgraenitz on Nov 1 2022, 2:55 AM.

Details

Summary

This test caught my attention because it's the only one in JITLink that XFAILs. Running it in isolation showed that the output doesn't meet the CHECK-LINES, i.e. the block address didn't match:

error: CHECK-NEXT: expected string not found in input
  CHECK-NEXT: block 0xfff02000 size = 0x00000001, align = 16, alignment-offset = 0

<stdin>:22:2: note: possible intended match here
              block 0xfff01000 size = 0x00000001, align = 16, alignment-offset = 0

Though, that doesn't appear to be the reason the test XFAILs. What we really want to check here is that llvm-jitlink doesn't fail with a duplicate section error yet.
In order to avoid issues like this in the future we can match a placeholder to check for some valid address within the slab (64Kb == last 4 digits).

The patch also drops the duplicate -noexec argument, removes an empty RUN-line, fixes indentation and adds a newline at EOF.

Diff Detail

Event Timeline

sgraenitz created this revision.Nov 1 2022, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 2:55 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
sgraenitz requested review of this revision.Nov 1 2022, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 2:55 AM
sunho accepted this revision.Nov 2 2022, 4:53 PM

LGTM!

This revision is now accepted and ready to land.Nov 2 2022, 4:53 PM
This revision was automatically updated to reflect the committed changes.