Allowing us to test this feature (context: a recent crash in
semantic highlighting.)
Details
Details
- Reviewers
kadircet - Commits
- rGe3ec9dd0ba42: [clangd] Run semantic highligting in clangd check.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/tool/Check.cpp | ||
---|---|---|
212 | can you also vlog the highlights, while limitting the output to ranges that intersect with the LineRange passed to check, when present. |
Comment Actions
thanks!
clang-tools-extra/clangd/tool/Check.cpp | ||
---|---|---|
213 | we should print all the highlights when LineRange is missing. so maybe turn this into: auto Highlights = ... for(const auto HL : ..) { if(!LineRange || LineRange->contains(HL.R)) vlog(...); } |
clang-tools-extra/clangd/tool/Check.cpp | ||
---|---|---|
213 | I was going to say this likely introduces too much noise to the output log, then I realized that we already did it for inlay hints, probably it is fine for verbose log... |
can you also vlog the highlights, while limitting the output to ranges that intersect with the LineRange passed to check, when present.