[lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

[augusto2112]

Summary

The python "open" function will use the default encoding for the
locale (the result of "locale.getpreferredencoding()"). Explicitly set
the locale to utf-8 when opening the crashlog for writing, as there may
be non-ascii symbols in there (for example, Swift uses "τ" to indicate
generic parameters).

rdar://101402755

[rupprecht]

Two other places you might need to update as well

lldb/examples/python/crashlog.py

452

Do you need to specify encoding here too?

647

(and here)

[JDevlieghere]

LGTM with @rupprecht's comments addressed.

[augusto2112]

Added encoding parameter to all "open" calls

[mib]

LGTM! Thanks Augusto!

lldb/examples/python/crashlog.py

def is_valid_json(path):
             try:
                 return json.loads(buffer)
             except:
                 # The first line can contain meta data. Try stripping it and
                 # try again.
                 head, _, tail = buffer.partition('\n')
                 return json.loads(tail)
 
-        with open(path, 'r') as f:
+        with open(path, 'r', encoding='utf-8') as f:
             buffer = f.read()
         try:
             return parse_json(buffer)
         except:
             return None
 
     def parse(self):
         try:
def __init__(self, debugger, path, verbose):
             CrashLogParseMode.THREAD : self.parse_thread,
             CrashLogParseMode.IMAGES : self.parse_images,
             CrashLogParseMode.THREGS : self.parse_thread_registers,
             CrashLogParseMode.SYSTEM : self.parse_system,
             CrashLogParseMode.INSTRS : self.parse_instructions,
         }
 
     def parse(self):
-        with open(self.path,'r') as f:
+        with open(self.path,'r', encoding='utf-8') as f:
             lines = f.read().splitlines()
 
         for line in lines:
             line_len = len(line)
             if line_len == 0:
                 if self.thread:
                     if self.parse_mode == CrashLogParseMode.THREAD:
                         if self.thread.index == self.crashlog.crashed_thread_idx:
try:
         (options, args) = parser.parse_args(shlex.split(command))
     except:
         result.PutCString("error: invalid options")
         return
     if len(args) != 1:
         result.PutCString(
             "error: invalid arguments, a single output file is the only valid argument")
         return
-    out_file = open(args[0], 'w')
+    out_file = open(args[0], 'w', encoding='utf-8')
     if not out_file:
         result.PutCString(
             "error: failed to open file '%s' for writing...",
             args[0])
         return
     target = exe_ctx.target
     if target:
         identifier = target.executable.basename