This is an archive of the discontinued LLVM Phabricator instance.

[FuncSpec][NFC] Fix test for literal constant specialisation
AbandonedPublic

Authored by chill on Oct 26 2022, 3:36 AM.

Details

Summary

[FuncSpec][NFC] Fix test for literal constant specialisation

The specialised function names depend in the order of specialisation,
which is the order as obtained by for (Function &F : M) { ... and
if this order is reversed tests that mention cloned function names
may break.

This patch fixes a failure triggered by -DLLVM_REVERSE_ITERATION:ON by
making the test not depend on specific cloned function names.

Diff Detail

Event Timeline

chill created this revision.Oct 26 2022, 3:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2022, 3:36 AM
chill requested review of this revision.Oct 26 2022, 3:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2022, 3:36 AM

Generally we'd revert the D135893, otherwise it'll exist without a test. Reverting is common in LLVM and it doesn't mean a lot.

chill planned changes to this revision.Oct 26 2022, 4:47 AM
chill updated this revision to Diff 470785.Oct 26 2022, 5:02 AM
chill retitled this revision from [FuncSpec][NFC] Disable test for literal constant specialisation to [FuncSpec][NFC] Fix test for literal constant specialisation.
chill edited the summary of this revision. (Show Details)
chill edited the summary of this revision. (Show Details)
chill abandoned this revision.Oct 26 2022, 5:55 AM