This is an archive of the discontinued LLVM Phabricator instance.

Differential D136184

[FuncSpec] Add a testcase for the treatment of constant and unused arguments
ClosedPublic

Authored by chill on Oct 18 2022, 9:51 AM.

Details

Reviewers
SjoerdMeijer
labrinea
Commits
rG5ea8951b8845: [FuncSpec] Add a testcase for the treatment of constant and unused arguments
Summary

Increase test coverage - check that functions are not specialised on
constant or unused arguments.

Diff Detail

Event Timeline

chill created this revision.Oct 18 2022, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 9:51 AM
chill requested review of this revision.Oct 18 2022, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 9:51 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chill added reviewers: SjoerdMeijer, labrinea.Oct 18 2022, 9:52 AM
chill mentioned this in D135968: [FuncSpec][NFC] Refactor finding specialisation opportunities .
Harbormaster completed remote builds in B192786: Diff 468599.Oct 18 2022, 11:15 AM
SjoerdMeijer accepted this revision.Oct 18 2022, 11:17 AM

Looks like a nice and concise test case to me.

This revision is now accepted and ready to land.Oct 18 2022, 11:17 AM
This revision was landed with ongoing or failed builds.Oct 26 2022, 9:38 AM
Closed by commit rG5ea8951b8845: [FuncSpec] Add a testcase for the treatment of constant and unused arguments (authored by chill). · Explain Why
This revision was automatically updated to reflect the committed changes.
chill added a commit: rG5ea8951b8845: [FuncSpec] Add a testcase for the treatment of constant and unused arguments.

Revision Contents

PathSize
llvm/
test/
Transforms/
FunctionSpecialization/
20 lines

Diff 468599

llvm/test/Transforms/FunctionSpecialization/no-spec-unused-arg.ll

  • This file was added.
; RUN: opt -S --passes=function-specialization -force-function-specialization -function-specialization-for-literal-constant < %s | FileCheck %s
define internal i32 @f(i32 %x, i32 %y) noinline {
ret i32 %x
}
define i32 @g0() {
%r = call i32 @f(i32 1, i32 1)
ret i32 %r
}
define i32 @g1() {
%r = call i32 @f(i32 1, i32 2)
ret i32 %r
}
; Check that there are no specialisation of `f`: first parameter is deduced
; to be a constant without the need for function specialisation and
; the second parameter is unused.
; CHECK-NOT: @f.
No newline at end of file