This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][WIP] Recompute liveins after eliminating prime/unprime operations
AbandonedPublic

Authored by lkail on Oct 17 2022, 9:13 PM.

Details

Reviewers
None

Diff Detail

Event Timeline

lkail created this revision.Oct 17 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 9:13 PM
lkail requested review of this revision.Oct 17 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 9:13 PM
shchenz added inline comments.Oct 17 2022, 11:26 PM
llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp
411

This really sounds like a 'hack' for a specific case but hurt other normal cases. For example, machine-verifier knows that a def of a user in the same block is removed by mistake(Using an undefined physical register). But now even the def is removed by mistake, machine verifier still thinks that this is valid MIR because it is told the def is from outside but actually there is also no def outside the block.

lkail abandoned this revision.Jan 8 2023, 10:25 PM

Will seek another method that's not hacky.