This is an archive of the discontinued LLVM Phabricator instance.

[win][compiler-rt] Make tests use lld-link instead of link
ClosedPublic

Authored by aeubanks on Oct 17 2022, 1:33 PM.

Details

Summary

Git bash ships with a link.exe. We try to add git bash to the beginning
of PATH (see D84380). These tests end up executing the wrong link.exe.

As a workaround, use lld-link. Note that REQUIRES: lld-available tests currently aren't running, see D128567. I did manually verify that these tests pass with lld-link.

Diff Detail

Event Timeline

aeubanks created this revision.Oct 17 2022, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 1:33 PM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
aeubanks requested review of this revision.Oct 17 2022, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 1:33 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aeubanks edited the summary of this revision. (Show Details)Oct 17 2022, 1:35 PM
aeubanks added reviewers: rnk, aganea, hans.
aeubanks edited the summary of this revision. (Show Details)Oct 17 2022, 1:37 PM
rnk accepted this revision.Oct 17 2022, 4:09 PM

lgtm

This revision is now accepted and ready to land.Oct 17 2022, 4:09 PM
hans accepted this revision.Oct 18 2022, 2:38 AM
This revision was landed with ongoing or failed builds.Oct 18 2022, 8:46 AM
This revision was automatically updated to reflect the committed changes.