This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Specify Triple in DebugInfo Tests
ClosedPublic

Authored by lenary on Oct 17 2022, 3:49 AM.

Details

Summary

When the host's target triple ends in -windows-msvc, %llc_dwarf
contains an explicit -windows-gnu triple which ensures that dwarf will
be used. This is useful in target-independent tests, where no triple is
specified, and no target-specific features are used. However, this is
not compatible with target-dependent tests (such as those in
llvm/test/DebugInfo/ARM), as the command-line triple will override the
triple in the LLVM IR program, causing test issues on windows.

This change switches these tests to use an explicit triple, so the tests
test what was expected, and there is no flakiness on windows.

Fixes #58053

Diff Detail

Event Timeline

lenary created this revision.Oct 17 2022, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 3:49 AM
lenary requested review of this revision.Oct 17 2022, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 3:49 AM
DavidSpickett added inline comments.Oct 17 2022, 4:14 AM
llvm/test/DebugInfo/ARM/float-args.ll
14–15

Worth removing the triples in the IR as well?

lenary marked an inline comment as done.Nov 1 2022, 7:45 AM
lenary marked an inline comment as not done.
lenary updated this revision to Diff 472300.Nov 1 2022, 7:52 AM
lenary marked an inline comment as done.Nov 1 2022, 7:52 AM
This revision is now accepted and ready to land.Nov 1 2022, 7:54 AM
This revision was landed with ongoing or failed builds.Nov 1 2022, 7:56 AM
This revision was automatically updated to reflect the committed changes.