This is an archive of the discontinued LLVM Phabricator instance.

Differential D135966

[X86] Use unsigned int for return type of __get_cpuid_max.
ClosedPublic

Authored by craig.topper on Oct 14 2022, 9:14 AM.

Details

Reviewers
RKSimon
pengfei
Commits
rG71a9b8833231: [X86] Use unsigned int for return type of __get_cpuid_max.
Summary

It looks like gcc's header already uses unsigned int and we should
match.

Fixes PR58359.

Diff Detail

Event Timeline

craig.topper created this revision.Oct 14 2022, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2022, 9:14 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
craig.topper requested review of this revision.Oct 14 2022, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2022, 9:14 AM
Harbormaster completed remote builds in B192192: Diff 467794.Oct 14 2022, 9:59 AM
RKSimon accepted this revision.Oct 14 2022, 11:19 AM

LGTM

This revision is now accepted and ready to land.Oct 14 2022, 11:19 AM
This revision was landed with ongoing or failed builds.Oct 14 2022, 11:45 AM
Closed by commit rG71a9b8833231: [X86] Use unsigned int for return type of __get_cpuid_max. (authored by craig.topper). · Explain Why
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG71a9b8833231: [X86] Use unsigned int for return type of __get_cpuid_max..

Revision Contents

PathSize
clang/
lib/
Headers/
3 lines

Diff 467794

clang/lib/Headers/cpuid.h

/*===---- cpuid.h - X86 cpu model detection --------------------------------=== /*===---- cpuid.h - X86 cpu model detection --------------------------------===
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
* *
* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
* See https://llvm.org/LICENSE.txt for license information. * See https://llvm.org/LICENSE.txt for license information.
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
* *
*===-----------------------------------------------------------------------=== *===-----------------------------------------------------------------------===
*/ */
▲ Show 20 Lines • Show All 247 Lines • ▼ Show 20 Lines
#define __cpuid_count(__leaf, __count, __eax, __ebx, __ecx, __edx) \ #define __cpuid_count(__leaf, __count, __eax, __ebx, __ecx, __edx) \
__asm(" xchgq %%rbx,%q1\n" \ __asm(" xchgq %%rbx,%q1\n" \
" cpuid\n" \ " cpuid\n" \
" xchgq %%rbx,%q1" \ " xchgq %%rbx,%q1" \
: "=a"(__eax), "=r" (__ebx), "=c"(__ecx), "=d"(__edx) \ : "=a"(__eax), "=r" (__ebx), "=c"(__ecx), "=d"(__edx) \
: "0"(__leaf), "2"(__count)) : "0"(__leaf), "2"(__count))
#endif #endif
static __inline int __get_cpuid_max (unsigned int __leaf, unsigned int *__sig) static __inline unsigned int __get_cpuid_max (unsigned int __leaf,
unsigned int *__sig)
{ {
unsigned int __eax, __ebx, __ecx, __edx; unsigned int __eax, __ebx, __ecx, __edx;
#if __i386__ #if __i386__
int __cpuid_supported; int __cpuid_supported;
__asm(" pushfl\n" __asm(" pushfl\n"
" popl %%eax\n" " popl %%eax\n"
" movl %%eax,%%ecx\n" " movl %%eax,%%ecx\n"
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines