This is an archive of the discontinued LLVM Phabricator instance.

Differential D135896

[clang] Fix clang version check in SARIF diagnostics test
ClosedPublic

Authored by yabinc on Oct 13 2022, 10:41 AM.

Details

Reviewers
aaron.ballman
srhines
pirama
Commits
rG4e6b071509d6: Fix clang version check in SARIF diagnostics test
Summary

This is to allow future clang versions and use of LLVM_VERSION_PATCH.

Diff Detail

Event Timeline

yabinc created this revision.Oct 13 2022, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 10:41 AM
yabinc requested review of this revision.Oct 13 2022, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 10:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yabinc added reviewers: aaron.ballman, srhines, pirama.Oct 13 2022, 10:44 AM
pirama accepted this revision.Oct 13 2022, 11:15 AM
pirama added a subscriber: abrahamcd.
This revision is now accepted and ready to land.Oct 13 2022, 11:15 AM
aaron.ballman accepted this revision.Oct 13 2022, 11:19 AM

LGTM!

Harbormaster completed remote builds in B192004: Diff 467532.Oct 13 2022, 11:58 AM
yabinc added a comment.Oct 13 2022, 12:01 PM

Thanks @aaron.ballman. I don’t have commit access, can you land this patch for me? Please use “Yabin Cui yabinc@google.com” to commit the change.

Closed by commit rG4e6b071509d6: Fix clang version check in SARIF diagnostics test (authored by yabinc, committed by aaron.ballman). · Explain WhyOct 13 2022, 12:17 PM
This revision was automatically updated to reflect the committed changes.
aaron.ballman added a commit: rG4e6b071509d6: Fix clang version check in SARIF diagnostics test.
aaron.ballman added a comment.Oct 13 2022, 12:17 PM
In D135896#3856506, @yabinc wrote:

Thanks @aaron.ballman. I don’t have commit access, can you land this patch for me? Please use “Yabin Cui yabinc@google.com” to commit the change.

Happy to do so, thank you for the fix!

vaibhav.y mentioned this in D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`.Nov 17 2022, 11:03 AM

Revision Contents

PathSize
clang/
test/
Frontend/
2 lines

Diff 467565

clang/test/Frontend/sarif-diagnostics.cpp

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
// CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"note","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"note","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration": // CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"{{[0-9]+}}","name":""},{"defaultConfiguration":
// CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription": // CHECK: {"enabled":true,"level":"error","rank":50},"fullDescription":
// CHECK: {"text":""},"id":"{{[0-9]+}}","name":""}],"version":"16.0.0"}}}],"version":"2.1.0"} // CHECK: {"text":""},"id":"{{[0-9]+}}","name":""}],"version":"{{[0-9]+\.[0-9]+\.[0-9]+}}"}}}],"version":"2.1.0"}
// CHECK: 2 warnings and 6 errors generated. // CHECK: 2 warnings and 6 errors generated.
No newline at end of file No newline at end of file