This is an archive of the discontinued LLVM Phabricator instance.

[lldb/crashlog] Fix the image_regex_uuid to skip null UUID images
ClosedPublic

Authored by mib on Oct 7 2022, 12:48 PM.

Details

Summary

`This patch updates the image_regex_uuid matcher to match null-UUID
images in the plain text crashlog parser.

It updates the regex to match one or more '?' characters or the image
full path.

rdar://100904019

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Oct 7 2022, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 12:48 PM
mib requested review of this revision.Oct 7 2022, 12:48 PM

Can we add a test for this?

mib updated this revision to Diff 466213.Oct 7 2022, 4:08 PM
  • Add test
  • Remove extra line
kastiglione accepted this revision.Oct 7 2022, 4:37 PM

lgtm now

This revision is now accepted and ready to land.Oct 7 2022, 4:37 PM