This is an archive of the discontinued LLVM Phabricator instance.

Differential D135482

[lldb/crashlog] Fix the image_regex_uuid to skip null UUID images
ClosedPublic

Authored by mib on Oct 7 2022, 12:48 PM.

Details

Reviewers
JDevlieghere
kastiglione
Commits
rG42df155ae628: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images
Summary

`This patch updates the image_regex_uuid matcher to match null-UUID
images in the plain text crashlog parser.

It updates the regex to match one or more '?' characters or the image
full path.

rdar://100904019

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Oct 7 2022, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 12:48 PM
mib requested review of this revision.Oct 7 2022, 12:48 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptOct 7 2022, 12:48 PM
Harbormaster completed remote builds in B191003: Diff 466160.Oct 7 2022, 12:50 PM
JDevlieghere added a comment.Oct 7 2022, 2:44 PM

Can we add a test for this?

mib updated this revision to Diff 466213.Oct 7 2022, 4:08 PM
  • Add test
  • Remove extra line
Harbormaster completed remote builds in B191043: Diff 466213.Oct 7 2022, 4:11 PM
mib added a parent revision: D135310: [lldb/crashlog] Add support for 32bit frame addresses.Oct 7 2022, 4:12 PM
kastiglione accepted this revision.Oct 7 2022, 4:37 PM

lgtm now

This revision is now accepted and ready to land.Oct 7 2022, 4:37 PM
mib added a child revision: D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items.Oct 10 2022, 1:47 PM
Closed by commit rG42df155ae628: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images (authored by mib). · Explain WhyNov 3 2022, 2:45 PM
This revision was automatically updated to reflect the committed changes.
mib added a commit: rG42df155ae628: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images.

Revision Contents

PathSize
lldb/
examples/
python/
2 lines
test/
Shell/
ScriptInterpreter/
Python/
Crashlog/
Inputs/
1 line

Diff 473038

lldb/examples/python/crashlog.py

Show First 20 Lines • Show All 617 Lines • ▼ Show 20 Lines frame_regex = re.compile(r'^(\d+)\s+' # id
) )
null_frame_regex = re.compile(r'^\d+\s+\?\?\?\s+0{4,} +') null_frame_regex = re.compile(r'^\d+\s+\?\?\?\s+0{4,} +')
image_regex_uuid = re.compile(r'(0x[0-9a-fA-F]+)' # img_lo image_regex_uuid = re.compile(r'(0x[0-9a-fA-F]+)' # img_lo
r'\s+-\s+' # - r'\s+-\s+' # -
r'(0x[0-9a-fA-F]+)\s+' # img_hi r'(0x[0-9a-fA-F]+)\s+' # img_hi
r'[+]?(.+?)\s+' # img_name r'[+]?(.+?)\s+' # img_name
r'(?:(' +version+ r')\s+)?' # img_version r'(?:(' +version+ r')\s+)?' # img_version
r'(?:<([-0-9a-fA-F]+)>\s+)?' # img_uuid r'(?:<([-0-9a-fA-F]+)>\s+)?' # img_uuid
r'(/.*)' # img_path r'(\?+|/.*)' # img_path
) )
exception_type_regex = re.compile(r'^Exception Type:\s+(EXC_[A-Z_]+)(?:\s+\((.*)\))?') exception_type_regex = re.compile(r'^Exception Type:\s+(EXC_[A-Z_]+)(?:\s+\((.*)\))?')
exception_codes_regex = re.compile(r'^Exception Codes:\s+(0x[0-9a-fA-F]+),\s*(0x[0-9a-fA-F]+)') exception_codes_regex = re.compile(r'^Exception Codes:\s+(0x[0-9a-fA-F]+),\s*(0x[0-9a-fA-F]+)')
exception_extra_regex = re.compile(r'^Exception\s+.*:\s+(.*)') exception_extra_regex = re.compile(r'^Exception\s+.*:\s+(.*)')
def __init__(self, debugger, path, verbose): def __init__(self, debugger, path, verbose):
super().__init__(debugger, path, verbose) super().__init__(debugger, path, verbose)
self.thread = None self.thread = None
▲ Show 20 Lines • Show All 686 Lines • Show Last 20 Lines

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/a.out.crash

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
Logical CPU: 2 Logical CPU: 2
Error Code: 0x00000006 (no mapping for user data write) Error Code: 0x00000006 (no mapping for user data write)
Trap Number: 14 Trap Number: 14
Binary Images: Binary Images:
0x100000000 - 0x200000000 +a.out (0) <@UUID@> @EXEC@ 0x100000000 - 0x200000000 +a.out (0) <@UUID@> @EXEC@
0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???