This is an archive of the discontinued LLVM Phabricator instance.

Differential D135373

[clang][test] Make headers unique to avoid linking issues
ClosedPublic

Authored by benlangmuir on Oct 6 2022, 9:18 AM.

Details

Reviewers
goncharov
dexonsmith
Commits
rG8d9a3a6b9bd1: [clang][test] Make headers unique to avoid linking issues
Summary

Make the empty headers used by cl-pch-showincludes.cpp unique so that filesystems that link these files together by contents will not see different behaviour in this test, which is not testing linked files specifically.

This was uncovered by 5ea78c4113f8 which made us stop mutating the name of the presumed loc for the file in ContentCache, but that just surfaced an underlying issue that the filename of multiple includes of linked files are not separately tracked.

Diff Detail

Event Timeline

benlangmuir created this revision.Oct 6 2022, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 9:18 AM
benlangmuir requested review of this revision.Oct 6 2022, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 9:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
benlangmuir mentioned this in D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef.Oct 6 2022, 9:19 AM
goncharov accepted this revision.Oct 6 2022, 9:32 AM

thank you!

This revision is now accepted and ready to land.Oct 6 2022, 9:32 AM
This revision was landed with ongoing or failed builds.Oct 6 2022, 10:09 AM
Closed by commit rG8d9a3a6b9bd1: [clang][test] Make headers unique to avoid linking issues (authored by benlangmuir). · Explain Why
This revision was automatically updated to reflect the committed changes.
benlangmuir added a commit: rG8d9a3a6b9bd1: [clang][test] Make headers unique to avoid linking issues.
Harbormaster completed remote builds in B190752: Diff 465767.Oct 6 2022, 10:39 AM

Revision Contents

PathSize
clang/
test/
Driver/
Inputs/
1 line
1 line
1 line
1 line
1 line

Diff 465780

clang/test/Driver/Inputs/header0.h

// header0.h

clang/test/Driver/Inputs/header1.h

// header1.h

clang/test/Driver/Inputs/header2.h

// header2.h
#include "header1.h" #include "header1.h"

clang/test/Driver/Inputs/header3.h

// header3.h

clang/test/Driver/Inputs/header4.h

// header4.h