This is an archive of the discontinued LLVM Phabricator instance.

Differential D135357

[llvm] [test] Add missing canonicalization of LLVM_ENABLE_ZSTD
ClosedPublic

Authored by mgorny on Oct 6 2022, 5:45 AM.

Details

Reviewers
nikic
phosek
MaskRay
leonardchan
ckissane
Commits
rGbc4bcbcfc820: [llvm] [test] Add missing canonicalization of LLVM_ENABLE_ZSTD
Summary

Add LLVM_ENABLE_ZSTD to llvm_canonicalize_cmake_booleans(). This is
needed to ensure that the substitutions in lit.site.cfg.py resolve
to correct Python booleans.

Diff Detail

Event Timeline

mgorny created this revision.Oct 6 2022, 5:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 5:45 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
mgorny requested review of this revision.Oct 6 2022, 5:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 5:45 AM
mgorny mentioned this in D134990: [CMake] Provide Findzstd module.Oct 6 2022, 5:45 AM
nikic accepted this revision.Oct 6 2022, 6:17 AM

LG

This revision is now accepted and ready to land.Oct 6 2022, 6:17 AM
Harbormaster completed remote builds in B190711: Diff 465705.Oct 6 2022, 6:41 AM
Closed by commit rGbc4bcbcfc820: [llvm] [test] Add missing canonicalization of LLVM_ENABLE_ZSTD (authored by mgorny). · Explain WhyOct 6 2022, 7:09 AM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rGbc4bcbcfc820: [llvm] [test] Add missing canonicalization of LLVM_ENABLE_ZSTD.

Revision Contents

PathSize
llvm/
test/
1 line

Diff 465719

llvm/test/CMakeLists.txt

llvm_canonicalize_cmake_booleans( llvm_canonicalize_cmake_booleans(
BUILD_SHARED_LIBS BUILD_SHARED_LIBS
LLVM_HAVE_LIBXAR LLVM_HAVE_LIBXAR
HAVE_OCAMLOPT HAVE_OCAMLOPT
LLVM_ENABLE_DIA_SDK LLVM_ENABLE_DIA_SDK
LLVM_ENABLE_FFI LLVM_ENABLE_FFI
LLVM_ENABLE_THREADS LLVM_ENABLE_THREADS
LLVM_ENABLE_CURL LLVM_ENABLE_CURL
LLVM_ENABLE_HTTPLIB LLVM_ENABLE_HTTPLIB
LLVM_ENABLE_ZLIB LLVM_ENABLE_ZLIB
LLVM_ENABLE_ZSTD
LLVM_ENABLE_LIBXML2 LLVM_ENABLE_LIBXML2
LLVM_INCLUDE_GO_TESTS LLVM_INCLUDE_GO_TESTS
LLVM_LINK_LLVM_DYLIB LLVM_LINK_LLVM_DYLIB
LLVM_TOOL_LTO_BUILD LLVM_TOOL_LTO_BUILD
LLVM_USE_INTEL_JITEVENTS LLVM_USE_INTEL_JITEVENTS
LLVM_BUILD_EXAMPLES LLVM_BUILD_EXAMPLES
LLVM_ENABLE_PLUGINS LLVM_ENABLE_PLUGINS
LLVM_BYE_LINK_INTO_TOOLS LLVM_BYE_LINK_INTO_TOOLS
▲ Show 20 Lines • Show All 234 Lines • Show Last 20 Lines