This is an archive of the discontinued LLVM Phabricator instance.

Add more generic builtin implementations to clspv's libclc SOURCES
ClosedPublic

Authored by aarongreig on Sep 29 2022, 8:57 AM.

Details

Reviewers
rjodinchr
kpet
Summary

These new builtins are added where the native equivalent as implemented by a conformant Vulkan driver was found to fail the OpenCL CTS.

This contribution is being made by Codeplay on behalf of Samsung.

Diff Detail

Event Timeline

aarongreig created this revision.Sep 29 2022, 8:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 8:57 AM
aarongreig requested review of this revision.Sep 29 2022, 8:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 8:57 AM
rjodinchr accepted this revision.Sep 29 2022, 9:08 AM
rjodinchr added a subscriber: rjodinchr.

I agree with everything there.
I have also seen fdim.cl being needed on some platforms.

libclc/clspv/lib/SOURCES
31

clc_tan.cl is already there

This revision is now accepted and ready to land.Sep 29 2022, 9:08 AM

Add fdim.cl, remove duplicate entry for clc_tan.cl.

aarongreig marked an inline comment as done.Sep 29 2022, 10:01 AM
aarongreig edited the summary of this revision. (Show Details)Oct 26 2022, 9:24 AM
kpet closed this revision.Feb 14 2023, 10:09 AM

Landed as f6cd46e07fcca123620afff96675171f8fe96124.