(Probably) fixes https://crbug.com/1355639
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/CodeGenCXX/microsoft-abi-member-pointers-debug-info.cpp | ||
---|---|---|
13 | might be worth checking what location this is, to show it's a good one? (the code added makes some choice about what location to ascribe to this call, so the test should probably verify that) |
Comment Actions
Sounds good to me.
(Ah, I see, that chrome bug actually hit the underlying problem, not even the verifier constraint - when the constraint is violated & not detected, then code gets inlined without being stitched up to the inline scope and you end up with instructions in a function where the function has one subprogram, but the scope chain of the instruction's location leads to a different subprogram - which is a problem/makes building the scope tree weird/not possible (because it's no longer a tree but a forest))
might be worth checking what location this is, to show it's a good one? (the code added makes some choice about what location to ascribe to this call, so the test should probably verify that)