This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Make various vector undefs legal
ClosedPublic

Authored by arsenm on Sep 27 2022, 11:54 AM.

Details

Reviewers
rampitec
Group Reviewers
Restricted Project
Summary

Surprisingly these were getting legalized to something
zero initialized.

This fixes an infinite loop when combining some vector types.
Also fixes zero initializing some undef values.

SimplifyDemandedVectorElts / SimplifyDemandedBits are not checking
for the legality of the output undefs they are replacing unused
operations with. This resulted in turnind vectors into undefs
that were later re-legalized back into zero vectors.

Diff Detail

Event Timeline

arsenm created this revision.Sep 27 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 11:54 AM
arsenm requested review of this revision.Sep 27 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 11:54 AM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Sep 27 2022, 12:03 PM
This revision is now accepted and ready to land.Sep 27 2022, 12:03 PM