This is an archive of the discontinued LLVM Phabricator instance.

Document use of Co-author-by git tag.
ClosedPublic

Authored by kristof.beyls on Sep 27 2022, 7:45 AM.

Details

Summary

We are already using the Co-author-by git tag, but don't have documentation in
our developer policy about it. Fix that.

Diff Detail

Event Timeline

kristof.beyls created this revision.Sep 27 2022, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 7:45 AM
kristof.beyls requested review of this revision.Sep 27 2022, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 7:45 AM
lattner accepted this revision.Sep 27 2022, 9:22 AM

Thank you for clarifying this!

This revision is now accepted and ready to land.Sep 27 2022, 9:22 AM
kristof.beyls added inline comments.Sep 28 2022, 2:56 AM
llvm/docs/DeveloperPolicy.rst
270

I've wondered what exactly to link to.
Rather than pointing to a manual on how to add those tags in a github-specific way, I wanted to point to something that explains why co-author-by tags are useful and what value they bring. The github blog post I'm pointing to in the link is the best I've found (after searching for maybe 5 minutes).
So, I think the link to the github blog is slightly better than a link to the github-specific manual page. That being said, I wouldn't be surprised if there is a better page to point to - it's just that I haven't found it.

This revision was landed with ongoing or failed builds.Sep 28 2022, 3:00 AM
This revision was automatically updated to reflect the committed changes.
arichardson added inline comments.
llvm/docs/DeveloperPolicy.rst
269

Shouldn't this be Co-authored-by? At least that's the form I've seen and used so far.

kristof.beyls marked an inline comment as done.Sep 29 2022, 10:44 PM
kristof.beyls added inline comments.
llvm/docs/DeveloperPolicy.rst
269

Thanks for noticing!
I've now fixed this in cdf03f763484