This is an archive of the discontinued LLVM Phabricator instance.

Create interfaces and tests for the overlapping replacements fix in clang-tidy.
ClosedPublic

Authored by angelgarcia on Oct 6 2015, 6:08 AM.

Diff Detail

Event Timeline

angelgarcia updated this revision to Diff 36614.Oct 6 2015, 6:08 AM
angelgarcia retitled this revision from to Create interfaces and tests for the overlapping replacements fix in clang-tidy..
angelgarcia updated this object.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
klimek added inline comments.Oct 6 2015, 6:13 AM
unittests/clang-tidy/OverlappingReplacementsTest.cpp
134

I'd split it up and give the tests better names. TestingChecksWorksAsExpected doesn't really give new information :)

angelgarcia updated this revision to Diff 36615.Oct 6 2015, 6:25 AM

This test was intended to ensure that we don't have a bug in the mock checks. I've split it up into one test for each mock check, I hope it is more descriptive now.

klimek accepted this revision.Oct 6 2015, 6:34 AM
klimek edited edge metadata.

LG

unittests/clang-tidy/OverlappingReplacementsTest.cpp
21

I'd add a comment here that we're defining a couple of checks that help us check different variants of overlapping results.

This revision is now accepted and ready to land.Oct 6 2015, 6:34 AM
angelgarcia updated this revision to Diff 36620.Oct 6 2015, 6:44 AM
angelgarcia edited edge metadata.

Explain why we have defined these mocks.

angelgarcia closed this revision.Oct 6 2015, 6:54 AM