No changes in clang-tidy yet.
Details
Details
- Reviewers
klimek - Commits
- rG32af5bc51a18: Create interfaces and tests for the overlapping replacements fix in clang-tidy.
rCTE249402: Create interfaces and tests for the overlapping replacements fix in clang-tidy.
rL249402: Create interfaces and tests for the overlapping replacements fix in clang-tidy.
Diff Detail
Diff Detail
Event Timeline
unittests/clang-tidy/OverlappingReplacementsTest.cpp | ||
---|---|---|
133 | I'd split it up and give the tests better names. TestingChecksWorksAsExpected doesn't really give new information :) |
Comment Actions
This test was intended to ensure that we don't have a bug in the mock checks. I've split it up into one test for each mock check, I hope it is more descriptive now.
Comment Actions
LG
unittests/clang-tidy/OverlappingReplacementsTest.cpp | ||
---|---|---|
22 | I'd add a comment here that we're defining a couple of checks that help us check different variants of overlapping results. |
I'd add a comment here that we're defining a couple of checks that help us check different variants of overlapping results.