[tests][msan] Use -fno-sanitize-memory-param-retval in tests
ClosedPublic
Actions

Authored by vitalybuka on Sep 26 2022, 4:44 PM.

Details

Reviewers

aeubanks
MaskRay

Commits

rG15805c030f31: [tests][msan] Use -fno-sanitize-memory-param-retval in tests

Summary

Supports either default of -f[no-]sanitize-memory-param-retval.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	1,490 ms	x64 debian > MemorySanitizer-X86_64.MemorySanitizer-X86_64::chained_origin.cpp Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=memory -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -gline-tables-only -fsanitize-memory-track-origins=2 -O3 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/msan/chained_origin.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/chained_origin.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/chained_origin.cpp.tmp >/var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/chained_origin.cpp.tmp.out 2>&1
	2,600 ms	x64 debian > MemorySanitizer-X86_64.MemorySanitizer-X86_64::noundef_analysis.cpp Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=memory -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -gline-tables-only /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/msan/noundef_analysis.cpp -fno-sanitize-memory-param-retval -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/noundef_analysis.cpp.tmp && /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/noundef_analysis.cpp.tmp >/var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/msan/X86_64/Output/noundef_analysis.cpp.tmp.out 2>&1

Event Timeline

vitalybuka created this revision.Sep 26 2022, 4:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 4:44 PM

Herald added a subscriber: Enna1. · View Herald Transcript

vitalybuka requested review of this revision.Sep 26 2022, 4:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 4:44 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

vitalybuka mentioned this in D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default.Sep 26 2022, 4:46 PM

Harbormaster completed remote builds in B188810: Diff 463050.Sep 26 2022, 5:04 PM

fix tests

vitalybuka added a reviewer: aeubanks.Sep 26 2022, 5:09 PM

LGTM. [rt] => [msan] ?

This revision is now accepted and ready to land.Sep 26 2022, 5:10 PM

Herald added a subscriber: StephenFan. · View Herald TranscriptSep 26 2022, 5:10 PM

aeubanks accepted this revision.Sep 26 2022, 5:13 PM

vitalybuka retitled this revision from [tests][rt] Use -fno-sanitize-memory-param-retval in tests to [tests][msan] Use -fno-sanitize-memory-param-retval in tests.Sep 26 2022, 5:21 PM

vitalybuka edited the summary of this revision. (Show Details)

This revision was landed with ongoing or failed builds.Sep 26 2022, 5:24 PM

Closed by commit rG15805c030f31: [tests][msan] Use -fno-sanitize-memory-param-retval in tests (authored by vitalybuka). · Explain Why

This revision was automatically updated to reflect the committed changes.

vitalybuka added a commit: rG15805c030f31: [tests][msan] Use -fno-sanitize-memory-param-retval in tests.

Harbormaster completed remote builds in B188814: Diff 463054.Sep 26 2022, 5:27 PM