This is an archive of the discontinued LLVM Phabricator instance.

Differential D134459

[OpenMP][NFC] Fix wavesize build warning in OMPGridValues
ClosedPublic

Authored by dpalermo on Sep 22 2022, 10:40 AM.

Details

Reviewers
dpalermo
JonChesterfield
ronlieb
jdoerfert
Commits
rG44c734af9a9a: [OpenMP][NFC] Fix wavesize build warning in OMPGridValues
Summary

This patch fixes a C++17 warning seen when building the OpenMP runtime.

Diff Detail

Event Timeline

dpalermo created this revision.Sep 22 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 10:40 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
dpalermo requested review of this revision.Sep 22 2022, 10:40 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 22 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B188218: Diff 462236.Sep 22 2022, 10:40 AM
ronlieb accepted this revision.Sep 22 2022, 10:53 AM

LGTM

This revision is now accepted and ready to land.Sep 22 2022, 10:53 AM
Closed by commit rG44c734af9a9a: [OpenMP][NFC] Fix wavesize build warning in OMPGridValues (authored by dpalermo). · Explain WhySep 22 2022, 2:54 PM
This revision was automatically updated to reflect the committed changes.
dpalermo added a commit: rG44c734af9a9a: [OpenMP][NFC] Fix wavesize build warning in OMPGridValues.

Revision Contents

PathSize
llvm/
include/
llvm/
Frontend/
OpenMP/
2 lines

Diff 462303

llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Linesstatic constexpr GV AMDGPUGridValues32 = {
32, // GV_Warp_Size 32, // GV_Warp_Size
128, // GV_Max_Teams 128, // GV_Max_Teams
896, // GV_SimpleBufferSize 896, // GV_SimpleBufferSize
1024, // GV_Max_WG_Size, 1024, // GV_Max_WG_Size,
256, // GV_Default_WG_Size 256, // GV_Default_WG_Size
}; };
template <unsigned wavesize> constexpr const GV &getAMDGPUGridValues() { template <unsigned wavesize> constexpr const GV &getAMDGPUGridValues() {
static_assert(wavesize == 32 || wavesize == 64); static_assert(wavesize == 32 || wavesize == 64, "Unexpected wavesize");
return wavesize == 32 ? AMDGPUGridValues32 : AMDGPUGridValues64; return wavesize == 32 ? AMDGPUGridValues32 : AMDGPUGridValues64;
} }
/// For Nvidia GPUs /// For Nvidia GPUs
static constexpr GV NVPTXGridValues = { static constexpr GV NVPTXGridValues = {
256, // GV_Slot_Size 256, // GV_Slot_Size
32, // GV_Warp_Size 32, // GV_Warp_Size
1024, // GV_Max_Teams 1024, // GV_Max_Teams
Show All 9 Lines