This is an archive of the discontinued LLVM Phabricator instance.

Differential D134341

[VE] Remove obsolete ANDrm patterns
ClosedPublic

Authored by kaz7 on Sep 21 2022, 2:07 AM.

Details

Reviewers
efocht
Commits
rGeaa263485d53: [VE] Remove obsolete ANDrm patterns
Summary

Remove obsolete ANDrm patterns for MIMM operands. We add these
translations to optimize commonly used cast operations before
we support MIMM operands directly by each isntruction. Such
translations are obsolete now.

Diff Detail

Event Timeline

kaz7 created this revision.Sep 21 2022, 2:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2022, 2:07 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
kaz7 requested review of this revision.Sep 21 2022, 2:07 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 21 2022, 2:07 AM
Harbormaster completed remote builds in B187916: Diff 461821.Sep 21 2022, 2:08 AM
efocht accepted this revision.Sep 21 2022, 3:14 AM

+1

This revision is now accepted and ready to land.Sep 21 2022, 3:14 AM
This revision was landed with ongoing or failed builds.Sep 21 2022, 3:23 AM
Closed by commit rGeaa263485d53: [VE] Remove obsolete ANDrm patterns (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rGeaa263485d53: [VE] Remove obsolete ANDrm patterns.

Revision Contents

PathSize
llvm/
lib/
Target/
VE/
11 lines

Diff 461840

llvm/lib/Target/VE/VEInstrInfo.td

Show First 20 Lines • Show All 2,258 Lines • ▼ Show 20 Lines
// bitconvert // bitconvert
def : Pat<(f64 (bitconvert i64:$src)), (COPY_TO_REGCLASS $src, I64)>; def : Pat<(f64 (bitconvert i64:$src)), (COPY_TO_REGCLASS $src, I64)>;
def : Pat<(i64 (bitconvert f64:$src)), (COPY_TO_REGCLASS $src, I64)>; def : Pat<(i64 (bitconvert f64:$src)), (COPY_TO_REGCLASS $src, I64)>;
def : Pat<(i32 (bitconvert f32:$op)), (l2i (SRALri (f2l $op), 32))>; def : Pat<(i32 (bitconvert f32:$op)), (l2i (SRALri (f2l $op), 32))>;
def : Pat<(f32 (bitconvert i32:$op)), (l2f (SLLri (i2l $op), 32))>; def : Pat<(f32 (bitconvert i32:$op)), (l2f (SLLri (i2l $op), 32))>;
// Optimize code A generated by `(unsigned char)c << 5` to B.
// A) sla.w.sx %s0, %s0, 5
// lea %s1, 224 ; 0xE0
// and %s0, %s0, %s1
// B) sla.w.sx %s0, %s0, 5
// and %s0, %s0, (56)0
def : Pat<(i32 (and i32:$val, 0xff)), (l2i (ANDrm (i2l $val), !add(56, 64)))>;
def : Pat<(i32 (and i32:$val, 0xffff)), (l2i (ANDrm (i2l $val), !add(48, 64)))>;
def : Pat<(i64 (and i64:$val, 0xffffffff)), (ANDrm $val, !add(32, 64))>;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Vector Instruction Pattern Stuff // Vector Instruction Pattern Stuff
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Custom intermediate ISDs. // Custom intermediate ISDs.
class IsVLVT<int OpIdx> : SDTCisVT<OpIdx,i32>; class IsVLVT<int OpIdx> : SDTCisVT<OpIdx,i32>;
def vec_broadcast : SDNode<"VEISD::VEC_BROADCAST", SDTypeProfile<1, 2, def vec_broadcast : SDNode<"VEISD::VEC_BROADCAST", SDTypeProfile<1, 2,
[SDTCisVec<0>, IsVLVT<2>]>>; [SDTCisVec<0>, IsVLVT<2>]>>;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines