Page MenuHomePhabricator

[clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`
ClosedPublic

Authored by jloser on Sep 20 2022, 2:37 PM.

Details

Summary

The docs mention that __builtin_reduce_add and __builtin_reduce_mul support
both integer and floating point element types, but only integer element types
are actually supported. See https://github.com/llvm/llvm-project/issues/57847,
and specifically,
https://github.com/llvm/llvm-project/blob/00874c48ea4d291908517afaab50d1dcbfb016c3/clang/lib/Sema/SemaChecking.cpp#L2631 for the fact that floating point element types are not supported yet.

Fix the docs to only mention support for integer element types.

Diff Detail

Event Timeline

jloser created this revision.Sep 20 2022, 2:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 2:37 PM
jloser requested review of this revision.Sep 20 2022, 2:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 2:37 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Sep 21 2022, 12:45 AM
jloser closed this revision.Sep 22 2022, 6:54 AM

This landed with https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. The revision didn't auto-close for some reason.

fhahn added a comment.Sep 22 2022, 7:34 AM

This landed with https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. The revision didn't auto-close for some reason.

You need to make sure the commit message includes Differential Revision: https://reviews.llvm.org/D134316 for it to auto-close.