This is an archive of the discontinued LLVM Phabricator instance.

Differential D134312

[HLSL] remove unnecessary abs attributes
ClosedPublic

Authored by bob80905 on Sep 20 2022, 1:56 PM.

Details

Reviewers
python3kgae
beanz
Commits
rGd76c654d02b6: [HLSL] remove unnecessary abs attributes
Summary

remove abs non-elementwise attribute statements, stick to elementwise.

Diff Detail

Event Timeline

bob80905 created this revision.Sep 20 2022, 1:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 1:56 PM
Herald added a subscriber: Anastasia. · View Herald Transcript
bob80905 requested review of this revision.Sep 20 2022, 1:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 1:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
beanz accepted this revision.Sep 20 2022, 2:03 PM

Doh... I should have caught this before I pushed your last change. Thanks!

This revision is now accepted and ready to land.Sep 20 2022, 2:03 PM
This revision was landed with ongoing or failed builds.Sep 20 2022, 2:05 PM
Closed by commit rGd76c654d02b6: [HLSL] remove unnecessary abs attributes (authored by bob80905, committed by beanz). · Explain Why
This revision was automatically updated to reflect the committed changes.
beanz added a commit: rGd76c654d02b6: [HLSL] remove unnecessary abs attributes.
Harbormaster completed remote builds in B187832: Diff 461693.Sep 20 2022, 3:01 PM

Revision Contents

PathSize
clang/
lib/
Headers/
hlsl/
5 lines

Diff 461701

clang/lib/Headers/hlsl/hlsl_intrinsics.h

Show All 9 Lines
#define _HLSL_HLSL_INTRINSICS_H_ #define _HLSL_HLSL_INTRINSICS_H_
__attribute__((availability(shadermodel, introduced = 6.0))) __attribute__((availability(shadermodel, introduced = 6.0)))
__attribute__((clang_builtin_alias(__builtin_hlsl_wave_active_count_bits))) uint __attribute__((clang_builtin_alias(__builtin_hlsl_wave_active_count_bits))) uint
WaveActiveCountBits(bool bBit); WaveActiveCountBits(bool bBit);
// abs builtins // abs builtins
__attribute__((clang_builtin_alias(__builtin_abs))) int abs(int In);
__attribute__((clang_builtin_alias(__builtin_labs))) int64_t abs(int64_t In);
__attribute__((clang_builtin_alias(__builtin_fabsf))) float abs(float In);
__attribute__((clang_builtin_alias(__builtin_fabs))) double abs(double In);
#ifdef __HLSL_ENABLE_16_BIT #ifdef __HLSL_ENABLE_16_BIT
__attribute__((clang_builtin_alias(__builtin_elementwise_abs))) __attribute__((clang_builtin_alias(__builtin_elementwise_abs)))
int16_t abs(int16_t); int16_t abs(int16_t);
__attribute__((clang_builtin_alias(__builtin_elementwise_abs))) __attribute__((clang_builtin_alias(__builtin_elementwise_abs)))
int16_t2 abs(int16_t2); int16_t2 abs(int16_t2);
__attribute__((clang_builtin_alias(__builtin_elementwise_abs))) __attribute__((clang_builtin_alias(__builtin_elementwise_abs)))
int16_t3 abs(int16_t3); int16_t3 abs(int16_t3);
__attribute__((clang_builtin_alias(__builtin_elementwise_abs))) __attribute__((clang_builtin_alias(__builtin_elementwise_abs)))
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines