This is an archive of the discontinued LLVM Phabricator instance.

[clang] Mention vector in the description for -mno-implict-float.
ClosedPublic

Authored by craig.topper on Sep 16 2022, 3:13 PM.

Details

Summary

As far as I understand, this disables all integer vectors too.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 16 2022, 3:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 3:13 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
craig.topper requested review of this revision.Sep 16 2022, 3:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 3:13 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
efriedma accepted this revision.Oct 31 2022, 2:15 PM

LGTM

We might want per-target documentation somewhere for what counts as an "floating point or vector instruction". It's not entirely obvious whether, for example, cvtss2si (%rax), %ecx is a floating-point instruction. But I don't think we can get much more clear in a one or two line description.

This revision is now accepted and ready to land.Oct 31 2022, 2:15 PM