Page MenuHomePhabricator

[Lanai] Fix useDeprecatedPositionallyEncodedOperands errors.
ClosedPublic

Authored by jyknight on Sep 16 2022, 1:55 PM.

Details

Summary

This is a follow-on to https://reviews.llvm.org/D134073.

Lanai was almost clean: the only issue is that 'bit' behaves
differently than 'bits<1>', because only the 'bits' type preserves
unresolved references via 'keepUnsetBits()' in
TableGen/Record.h. Thus, use bits instead.

This issue _would_ have caused invalid instruction emission/decoding,
except that the PQ bits were being overriden after the fact by code in
'adjustPqBits' in MCTargetDesc/LanaiMCCodeEmitter.cpp, and
'PostOperandDecodeAdjust' in Disassembler/LanaiDisassembler.cpp.

Diff Detail

Event Timeline

jyknight created this revision.Sep 16 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 1:55 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
jyknight requested review of this revision.Sep 16 2022, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 1:55 PM
jpienaar accepted this revision.Sep 16 2022, 1:57 PM

Thanks!

This revision is now accepted and ready to land.Sep 16 2022, 1:57 PM
This revision was landed with ongoing or failed builds.Sep 25 2022, 2:55 PM
This revision was automatically updated to reflect the committed changes.