This is an archive of the discontinued LLVM Phabricator instance.

[libc][cmake] separate installing headers
ClosedPublic

Authored by michaelrj on Sep 15 2022, 11:26 AM.

Details

Summary

Now libc headers can be installed separately from installing the rest of
the libc.

Diff Detail

Event Timeline

michaelrj created this revision.Sep 15 2022, 11:26 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 15 2022, 11:26 AM
michaelrj requested review of this revision.Sep 15 2022, 11:26 AM
sivachandra accepted this revision.Sep 15 2022, 11:28 PM
sivachandra added inline comments.
libc/CMakeLists.txt
153

Since a real target is being added now, the whole block from line 144 to 165 should be moved to right before line 195.

This revision is now accepted and ready to land.Sep 15 2022, 11:28 PM
michaelrj added inline comments.Sep 16 2022, 2:12 PM
libc/CMakeLists.txt
153

I don't think we should move it since LIBC_TARGET and LIBC_COMPONENT are used in some of the folders below. Specifically LIBC_TARGET is used in lib and test and LIBC_COMPONENT is used in lib and loader.

sivachandra added inline comments.Sep 16 2022, 2:15 PM
libc/CMakeLists.txt
153

Ah, ok! Move just the new install target addition then?

michaelrj updated this revision to Diff 460906.Sep 16 2022, 2:31 PM
michaelrj marked 2 inline comments as done.

move target down

This revision was automatically updated to reflect the committed changes.