This is an archive of the discontinued LLVM Phabricator instance.

Differential D133854

[lld-macho] Fix -force_symbols_{,not_}weak_list arg type
ClosedPublic

Authored by lewurm on Sep 14 2022, 5:25 AM.

Details

Reviewers
int3
ributzka
thakis
Group Reviewers
Restricted Project
Commits
rG2769ceb0e7a4: [lld-macho] Fix -force_symbols_{,not_}weak_list arg type
Summary

This is still undocumented and unsupported, but if someone passed it before you would end up with a missing file error since this takes an argument that wouldn't be handled.

Diff Detail

Event Timeline

lewurm created this revision.Sep 14 2022, 5:25 AM
Herald added a reviewer: ributzka. · View Herald TranscriptSep 14 2022, 5:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
lewurm requested review of this revision.Sep 14 2022, 5:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2022, 5:25 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B186592: Diff 460046.Sep 14 2022, 5:54 AM
thakis accepted this revision.Sep 14 2022, 10:10 AM
thakis added a subscriber: thakis.

Makes sense to me. Since it's still unimplemented, i think it's fine to not include a test.

Do you need someone to land this for you? If so, what name and email address do you want to use for the commit?

This revision is now accepted and ready to land.Sep 14 2022, 10:10 AM
thakis added a comment.Sep 26 2022, 11:13 AM
In D133854#3789979, @thakis wrote:

Makes sense to me. Since it's still unimplemented, i think it's fine to not include a test.

Do you need someone to land this for you? If so, what name and email address do you want to use for the commit?

lewurm: ping ^

lewurm added a comment.Sep 26 2022, 11:37 AM

Sorry, I need the "okay" from my employer and I haven't managed to find the right person yet :-/

lewurm added a comment.Sep 27 2022, 2:17 AM

I got the okay :-) Yes, I need someone to land it. Please use "Bernhard Urban-Forster <bernhard.urban-forster@oracle.com>" as name/email.

Thanks for the quick review and sorry again for the delay.

Closed by commit rG2769ceb0e7a4: [lld-macho] Fix -force_symbols_{,not_}weak_list arg type (authored by lewurm, committed by thakis). · Explain WhySep 27 2022, 7:37 AM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG2769ceb0e7a4: [lld-macho] Fix -force_symbols_{,not_}weak_list arg type.
thakis added a comment.Sep 27 2022, 7:37 AM

Thanks for the patch!

Revision Contents

PathSize
lld/
MachO/
4 lines

Diff 463233

lld/MachO/Options.td

Show First 20 Lines • Show All 1,240 Lines • ▼ Show 20 Lines
def force_symbol_not_weak : Flag<["-"], "force_symbol_not_weak">, def force_symbol_not_weak : Flag<["-"], "force_symbol_not_weak">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def force_symbols_coalesce_list : Flag<["-"], "force_symbols_coalesce_list">, def force_symbols_coalesce_list : Flag<["-"], "force_symbols_coalesce_list">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def force_symbols_not_weak_list : Flag<["-"], "force_symbols_not_weak_list">, def force_symbols_not_weak_list : Separate<["-"], "force_symbols_not_weak_list">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def force_symbols_weak_list : Flag<["-"], "force_symbols_weak_list">, def force_symbols_weak_list : Separate<["-"], "force_symbols_weak_list">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def force_symbol_weak : Flag<["-"], "force_symbol_weak">, def force_symbol_weak : Flag<["-"], "force_symbol_weak">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def function_starts : Flag<["-"], "function_starts">, def function_starts : Flag<["-"], "function_starts">,
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines