This is an archive of the discontinued LLVM Phabricator instance.

Differential D133750

[Bazel] Bump bazel version to 5.0.
ClosedPublic

Authored by csigg on Sep 13 2022, 12:04 AM.

Details

Reviewers
mehdi_amini
Commits
rGd3081133549c: [Bazel] Bump bazel version to 5.0.
Summary

See https://discourse.llvm.org/t/use-bazelisk-for-bazel-buildbots/65188.

Diff Detail

Event Timeline

csigg created this revision.Sep 13 2022, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 12:04 AM
Herald added a subscriber: sanjoy.google. · View Herald Transcript
csigg requested review of this revision.Sep 13 2022, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 12:04 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B186307: Diff 459658.Sep 13 2022, 12:18 AM
mehdi_amini accepted this revision.Sep 13 2022, 9:03 AM

LG but I think it'd be better to rebase to get a passing pre-merge build.

This revision is now accepted and ready to land.Sep 13 2022, 9:03 AM
csigg updated this revision to Diff 459798.Sep 13 2022, 10:28 AM

Rebase.

csigg added a comment.Sep 13 2022, 10:30 AM
In D133750#3786735, @mehdi_amini wrote:

LG but I think it'd be better to rebase to get a passing pre-merge build.

Thanks Mehdi. I'm pretty sure this is safe because https://reviews.llvm.org/D133455 passed the bazel presubmit.
But given my recent track record of messing things up, I will wait for an extra green pre-merge check. ;-)

Harbormaster completed remote builds in B186406: Diff 459798.Sep 13 2022, 10:43 AM
Closed by commit rGd3081133549c: [Bazel] Bump bazel version to 5.0. (authored by csigg). · Explain WhySep 13 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.
csigg added a commit: rGd3081133549c: [Bazel] Bump bazel version to 5.0..

Revision Contents

PathSize
utils/
bazel/
2 lines

Diff 459818

utils/bazel/.bazelversion

4.0.0 5.0.0