One-shot-bufferize: allow non-tensor arguments in scg.while/for.
ClosedPublic
Actions

Authored by jreiffers on Sep 7 2022, 5:36 AM.

Details

Reviewers

Commits

rGfb9fc79809d5: One-shot-bufferize: allow non-tensor arguments in scg.while/for.

Summary

Currently, one-shot-bufferize crashes as soon as there's
a mixture of tensor and non-tensor arguments. This seems
to happen for no good reason.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jreiffers created this revision.Sep 7 2022, 5:36 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 5:36 AM

Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript

jreiffers requested review of this revision.Sep 7 2022, 5:36 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 5:36 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B185397: Diff 458432.Sep 7 2022, 5:59 AM

springerm accepted this revision.Sep 7 2022, 6:32 AM

This revision is now accepted and ready to land.Sep 7 2022, 6:32 AM

Closed by commit rGfb9fc79809d5: One-shot-bufferize: allow non-tensor arguments in scg.while/for. (authored by jreiffers). · Explain WhySep 7 2022, 6:54 AM

This revision was automatically updated to reflect the committed changes.

jreiffers added a commit: rGfb9fc79809d5: One-shot-bufferize: allow non-tensor arguments in scg.while/for..

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Dialect/

SCF/

Transforms/

BufferizableOpInterfaceImpl.cpp

20 lines

test/

Dialect/

SCF/

one-shot-bufferize.mlir

27 lines

Diff 458441

View Options

mlir/lib/Dialect/SCF/Transforms/BufferizableOpInterfaceImpl.cpp