This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Handle non-canonical triples with new runtime lib layout
ClosedPublic

Authored by ro on Sep 7 2022, 2:02 AM.

Details

Summary

As described in Issue #54196, the ideas of clang and compiler-rt where runtime libs are located with -DLLVM_ENABLE_RUNTIMES can differ. This is the compiler-rt side of the patch I've used to get them in sync for the amd64-pc-solaris2.11 and sparc64-unknown-linux-gnu release builds.

Tested on amd64-pc-solaris2.11 and sparc64-unknown-linux-gnu.

I don't expect this to be ready as is, just posting for reference.

Diff Detail

Event Timeline

ro created this revision.Sep 7 2022, 2:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 2:02 AM
ro requested review of this revision.Sep 7 2022, 2:02 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptSep 7 2022, 2:02 AM
MaskRay accepted this revision.Sep 9 2022, 2:00 PM

Nice if we just need these lines to solve the problem.

Have you made some investigation whether this is the best place doing the normalization? Are there other places normalizing arch?

This revision is now accepted and ready to land.Sep 9 2022, 2:00 PM
ro added a comment.Sep 11 2022, 2:23 AM

Have you made some investigation whether this is the best place doing the normalization? Are there other places normalizing arch?

I did, and everything converged here. The fact that the Android i386 -> i686 normalization already happens here suggests that it's the right place.