Page MenuHomePhabricator

[ASan] Show memory rather than tag addresses in tag dump
ClosedPublic

Authored by fmayer on Sep 6 2022, 6:05 PM.

Diff Detail

Event Timeline

fmayer created this revision.Sep 6 2022, 6:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 6:05 PM
fmayer requested review of this revision.Sep 6 2022, 6:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 6:05 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Sep 7 2022, 12:42 PM

LGTM

Maybe add a few compile-time checks that mem->shadow->mem returns the original value? At least the sparc equations are complicated enough.

This revision is now accepted and ready to land.Sep 7 2022, 12:42 PM

Well compile-time may be hard. Hwasan does some runtime checks in InitShadow, that's ok too

fmayer updated this revision to Diff 458539.Sep 7 2022, 12:51 PM

add static assert

fmayer added a comment.Sep 7 2022, 1:05 PM

LGTM

Maybe add a few compile-time checks that mem->shadow->mem returns the original value? At least the sparc equations are complicated enough.

Done. Cross-compiled compiler-rt for SPARC64 to verify the assertion doesn't fail (it fails at the link step, but compilation works fine).

This revision was automatically updated to reflect the committed changes.