This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix CommunicationKDP following D133251
ClosedPublic

Authored by kastiglione on Sep 6 2022, 10:21 AM.

Details

Summary

Add m_bytes and m_bytes_mutex to CommunicationKDP, following refactoring
in D133251.

Diff Detail

Event Timeline

kastiglione created this revision.Sep 6 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 10:21 AM
kastiglione requested review of this revision.Sep 6 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 10:21 AM

Note that these two fields are only used in CommunicationKDP::CheckForPacket.

mgorny accepted this revision.Sep 6 2022, 10:37 AM

That's the same thing that I did for gdb-remote, so I suppose it is correct.

This revision is now accepted and ready to land.Sep 6 2022, 10:37 AM

… and thanks a lot for doing this.

This revision was automatically updated to reflect the committed changes.

thanks for the fast reply