This is an archive of the discontinued LLVM Phabricator instance.

Differential D133316

[OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused
ClosedPublic

Authored by nikic on Sep 5 2022, 8:30 AM.

Details

Reviewers
jhuber6
jdoerfert
Commits
rG71797797f7a7: [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused
Summary

This matches the behavior for all the other -fopenmp options, as well as -frtlib-add-rpath.

For context, Fedora passes this flag by default in case OpenMP is used, and this results in a warning if it (usually) isn't, which causes build failures for some programs with unnecessarily strict build systems (like Ruby).

Diff Detail

Event Timeline

nikic created this revision.Sep 5 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 8:30 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
nikic requested review of this revision.Sep 5 2022, 8:30 AM
Herald added a subscriber: sstefan1. · View Herald TranscriptSep 5 2022, 8:30 AM
Harbormaster completed remote builds in B185111: Diff 458013.Sep 5 2022, 9:06 AM
jhuber6 accepted this revision.Sep 5 2022, 9:44 AM

LG, thanks.

This revision is now accepted and ready to land.Sep 5 2022, 9:44 AM
Closed by commit rG71797797f7a7: [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused (authored by nikic). · Explain WhySep 6 2022, 12:44 AM
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG71797797f7a7: [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused.
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 12:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
include/
clang/
Driver/
3 lines

Diff 458112

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,108 Lines • ▼ Show 20 Lines
def frtlib_add_rpath: Flag<["-"], "frtlib-add-rpath">, Flags<[NoArgumentUnused]>, def frtlib_add_rpath: Flag<["-"], "frtlib-add-rpath">, Flags<[NoArgumentUnused]>,
HelpText<"Add -rpath with architecture-specific resource directory to the linker flags">; HelpText<"Add -rpath with architecture-specific resource directory to the linker flags">;
def fno_rtlib_add_rpath: Flag<["-"], "fno-rtlib-add-rpath">, Flags<[NoArgumentUnused]>, def fno_rtlib_add_rpath: Flag<["-"], "fno-rtlib-add-rpath">, Flags<[NoArgumentUnused]>,
HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">; HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">;
defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath",
LangOpts<"OpenMP">, LangOpts<"OpenMP">,
DefaultTrue, DefaultTrue,
PosFlag<SetTrue, [], "Set rpath on OpenMP executables">, PosFlag<SetTrue, [], "Set rpath on OpenMP executables">,
NegFlag<SetFalse>>; NegFlag<SetFalse>,
BothFlags<[NoArgumentUnused]>>;
def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>, def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>,
Group<Link_Group>; Group<Link_Group>;
def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, FlangOption, NoXarchOption]>, def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, FlangOption, NoXarchOption]>,
HelpText<"Save intermediate compilation results.">; HelpText<"Save intermediate compilation results.">;
def save_temps : Flag<["-", "--"], "save-temps">, Flags<[FlangOption, NoXarchOption]>, def save_temps : Flag<["-", "--"], "save-temps">, Flags<[FlangOption, NoXarchOption]>,
Alias<save_temps_EQ>, AliasArgs<["cwd"]>, Alias<save_temps_EQ>, AliasArgs<["cwd"]>,
HelpText<"Save intermediate compilation results">; HelpText<"Save intermediate compilation results">;
def save_stats_EQ : Joined<["-", "--"], "save-stats=">, Flags<[NoXarchOption]>, def save_stats_EQ : Joined<["-", "--"], "save-stats=">, Flags<[NoXarchOption]>,
▲ Show 20 Lines • Show All 2,800 Lines • Show Last 20 Lines