Differential D133285

Add ArithBuilder::sub, make add, mul work with IndexTypes.
ClosedPublic
Actions

Authored by jreiffers on Sep 5 2022, 2:28 AM.

Details

Reviewers

pifon2a

Commits

rG34f4a9ef2a1d: Add ArithBuilder::sub, make add, mul work with IndexTypes.

Summary

sgt and slt already worked with IndexTypes, the others did not.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jreiffers created this revision.Sep 5 2022, 2:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 2:28 AM

Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript

jreiffers requested review of this revision.Sep 5 2022, 2:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 2:28 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Thank you. I wonder, why it was not added before...

This revision is now accepted and ready to land.Sep 5 2022, 2:39 AM

Harbormaster completed remote builds in B185049: Diff 457911.Sep 5 2022, 2:47 AM

Closed by commit rG34f4a9ef2a1d: Add ArithBuilder::sub, make add, mul work with IndexTypes. (authored by jreiffers). · Explain WhySep 5 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

jreiffers added a commit: rG34f4a9ef2a1d: Add ArithBuilder::sub, make add, mul work with IndexTypes..

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

Arithmetic/

Utils/

Utils.h

1 line

lib/

Dialect/

Arithmetic/

Utils/

Utils.cpp

29 lines

Diff 457924

View Options

mlir/include/mlir/Dialect/Arithmetic/Utils/Utils.h