This is an archive of the discontinued LLVM Phabricator instance.

Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.
ClosedPublic

Authored by MaggieYi on Sep 2 2022, 2:37 AM.

Details

Summary

When testing clang that has been compiled with -DDEFAULT_SYSROOT set to some path, ps4-ps5-header-search.c would fail.

The test needs to be updated.

  1. Remove unnecessary REQUIRES: x86-registered-target.
  2. Override sysroot to be empty string for the test to succeed when clang is configured with DEFAULT_SYSROOT.

Diff Detail

Event Timeline

MaggieYi created this revision.Sep 2 2022, 2:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 2:37 AM
Herald added a subscriber: pengfei. · View Herald Transcript
MaggieYi requested review of this revision.Sep 2 2022, 2:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 2:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
wristow accepted this revision.Sep 2 2022, 11:49 AM

LGTM

This revision is now accepted and ready to land.Sep 2 2022, 11:49 AM
probinson closed this revision.Sep 7 2022, 1:39 PM

Closing this for @MaggieYi the commit message didn't cite the Phabricator review.
https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c