This is an archive of the discontinued LLVM Phabricator instance.

Differential D133105

[Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`
ClosedPublic

Authored by egorzhdan on Sep 1 2022, 5:31 AM.

Details

Reviewers
aaronpuchert
Commits
rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`
Summary

This re-enables a test after it was disabled in https://reviews.llvm.org/D133009.

Fixes #57484.

Diff Detail

Event Timeline

egorzhdan created this revision.Sep 1 2022, 5:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2022, 5:31 AM
Herald added a subscriber: arphaman. · View Herald Transcript
egorzhdan requested review of this revision.Sep 1 2022, 5:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2022, 5:31 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B184556: Diff 457237.Sep 1 2022, 6:27 AM
aaronpuchert accepted this revision.Sep 1 2022, 2:23 PM

Thanks!

This revision is now accepted and ready to land.Sep 1 2022, 2:23 PM
Closed by commit rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c` (authored by egorzhdan). · Explain WhySep 2 2022, 4:34 AM
This revision was automatically updated to reflect the committed changes.
egorzhdan added a commit: rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`.

Revision Contents

PathSize
clang/
test/
Index/
26 lines

Diff 457558

clang/test/Index/comment-lots-of-unknown-commands.c

// RUN: c-index-test -test-load-source-reparse 1 local %s | FileCheck %s // RUN: c-index-test -test-load-source-reparse 1 local %s | FileCheck %s
// XFAIL: *
// See PR 21254. We had too few bits to encode command IDs so if you created // See PR 21254. We had too few bits to encode command IDs so if you created
// enough of them the ID codes would wrap around. This test creates commands up // enough of them the ID codes would wrap around. This test creates commands up
// to an ID of 258. Ideally we should check for large numbers, but that would // to an ID of 258. Ideally we should check for large numbers, but that would
// require a test source file which is megabytes in size. This is the test case // require a test source file which is megabytes in size. This is the test case
// from the PR. // from the PR.
/** /**
@s @s
Show All 19 Lines
@l @l
@x @x
@R @R
@ute @ute
@am @am
@ei @ei
@oun @oun
@ou @ou
@nl @nlnl
@ien @ien
@fr @fr
@en @en
@teq @teq
@le @le
@L @L
@os @os
@A @A
@ro @ro
@o @o
@ho @ho
@ca @ca
@Tie @Tie
@tl @tl
@g @g
@hr @hr
@et @et
@fro @fro
@ast @ast
@ae @ae
@nN @nNnN
@pc @pc
@tae @tae
@ws @ws
@ia @ia
@N @N
@lc @lc
@psg @psg
@ta @ta
▲ Show 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
@rt @rt
@to @to
@isj @isj
@fo @fo
@i @i
@an @an
@de @de
@tel @tel
@nd @ndnd
@dic @dict
@Lo @Lo
@il @ilil
@tle @tle
@axt @axt
@ba @ba
@ust @ust
@ac @ac
@tpe @tpe
@tpl @tpl
@ctG @ctG
@ru @ru
@m @m
@tG @tG
@it @itit
@rh @rh
@G @G
@rpc @rpc
@el @el
@er @er
@w @w
@eo @eo
@tx @tx
Show All 29 Lines
// CHECK: (CXComment_InlineCommand CommandName=[l] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[l] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[x] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[x] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[R] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[R] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ute] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ute] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[am] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[am] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ei] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ei] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[oun] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[oun] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ou] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ou] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[nl] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[nlnl] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ien] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ien] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[fr] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[fr] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[en] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[en] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[teq] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[teq] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[le] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[le] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[L] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[L] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[os] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[os] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[A] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[A] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ro] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ro] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[o] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[o] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ho] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ho] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ca] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ca] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[Tie] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[Tie] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tl] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tl] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[g] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[g] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[hr] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[hr] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[et] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[et] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[fro] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[fro] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ast] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ast] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ae] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ae] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[nN] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[nNnN] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[pc] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[pc] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tae] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tae] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ws] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ws] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ia] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ia] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[N] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[N] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[lc] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[lc] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[psg] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[psg] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ta] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ta] RenderNormal HasTrailingNewline)
▲ Show 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
// CHECK: (CXComment_InlineCommand CommandName=[rt] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[rt] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[to] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[to] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[isj] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[isj] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[fo] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[fo] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[i] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[i] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[an] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[an] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[de] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[de] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tel] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tel] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[nd] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ndnd] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[dic] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[dict] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[Lo] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[Lo] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[il] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ilil] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tle] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tle] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[axt] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[axt] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ba] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ba] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ust] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ust] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ac] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ac] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tpe] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tpe] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tpl] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tpl] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ctG] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ctG] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[ru] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[ru] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[m] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[m] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tG] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tG] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[it] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[itit] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[rh] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[rh] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[G] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[G] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[rpc] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[rpc] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[el] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[el] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[er] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[er] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[w] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[w] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[eo] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[eo] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[tx] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[tx] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[oo] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[oo] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[dD] RenderNormal HasTrailingNewline) // CHECK: (CXComment_InlineCommand CommandName=[dD] RenderNormal HasTrailingNewline)
// CHECK: (CXComment_InlineCommand CommandName=[dD] RenderNormal)))] // CHECK: (CXComment_InlineCommand CommandName=[dD] RenderNormal)))]